Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to ls and stat to process arbitrary metadata keys #905

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Add logic to ls and stat to process arbitrary metadata keys #905

merged 2 commits into from
Jun 30, 2020

Conversation

ishank011
Copy link
Contributor

@ishank011 ishank011 commented Jun 29, 2020 •
edited
Loading

Closes #806

@ishank011 ishank011 requested a review from labkode as a code owner June 29, 2020 16:09
labkode
labkode approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@labkode labkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use variadic functions for signature:

func test(keys ...string)

@ishank011 ishank011 marked this pull request as draft June 30, 2020 07:31
@ishank011 ishank011 marked this pull request as ready for review June 30, 2020 07:46
@ishank011
Copy link
Contributor Author

Thanks for the review @labkode! Made the change.

@butonic butonic merged commit 419de24 into cs3org:master Jun 30, 2020
@ishank011 ishank011 deleted the stat-metadata-keys branch July 3, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode labkode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify stat to take metadata fields to be read as parameters
3 participants
@ishank011 @labkode @butonic