downgrade grpc to 1.26.0 #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ocis we currently face the problem that some of our dependencies rely on grpc 1.26.0. With the upgraded grpc dependency in reva we were unable to build ocis. And if we upgrade grpc in ocis the build failed because of the other dependency. I hoped we could downgrade grpc in reva until we have found a better long term solution. Here are some examples of our attempts to resolve this without this downgrade. owncloud/ocis#328 (comment)
labkode
approved these changes
Jun 24, 2020
labkode
approved these changes
Jun 24, 2020
|
@C0rby temporary downgrading, please tackle this issue also on your repo. |
C0rby
added a commit
to owncloud/reva
that referenced
this pull request
Jun 30, 2020
|
@C0rby any update on when we can revert this downgrade? |
|
@ishank011, sadly one library we are using is still depending on that downgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ocis we currently face the problem that some of our dependencies rely on
grpc 1.26.0. With the upgraded grpc dependency in reva we were unable to
build ocis. And if we upgrade grpc in ocis the build failed because of
the other dependency.
I hoped we could downgrade grpc in reva until we have found a better
long term solution.
Here are some examples of our attempts to resolve this without this
downgrade. owncloud/ocis#328 (comment)