Remove redundant build tags from local and owncloud fs #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkode
approved these changes
Jun 12, 2020
|
it seems that it's causing Windows builds to fail now: https://cloud.drone.io/owncloud/ocis-reva/492/8/3 not sure why... Golang is supposed to recognize those files based on the underscore but is still reading both versions of the file, causing duplicate symbol issues. can we revert for now ? |
This was referenced Jun 22, 2020
|
revert PR here: #862 |
ishank011
pushed a commit
that referenced
this pull request
Jun 22, 2020
C0rby
pushed a commit
to owncloud/reva
that referenced
this pull request
Jun 30, 2020
C0rby
pushed a commit
to owncloud/reva
that referenced
this pull request
Jun 30, 2020
This reverts commit 53c922c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.