Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST driver for user pkg #747

Merged
merged 3 commits into from
May 20, 2020
Merged

REST driver for user pkg #747

merged 3 commits into from
May 20, 2020

Conversation

ishank011
Copy link
Contributor

No description provided.

@labkode
Copy link
Member

labkode commented May 15, 2020

@ishank011 once you are done with this next week let's have a call so you can guide me though :)

@ishank011
Copy link
Contributor Author

@labkode yes, definitely. I'm still getting some weird unmarshalling errors while parsing the response. I'll just resolve that.

@ishank011 ishank011 marked this pull request as ready for review May 18, 2020 08:44
@ishank011 ishank011 requested a review from labkode as a code owner May 18, 2020 08:44
@ishank011
Copy link
Contributor Author

Hi Hugo. Thanks for the review. Addressed your comments.

@labkode labkode merged commit df2c4b1 into cs3org:master May 20, 2020
@ishank011 ishank011 deleted the grappa_driver branch May 20, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkode labkode labkode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishank011 @labkode