-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal tus implementation #669
Conversation
Hm, I think I could even leave out the ocdav changes. |
7052e56
to
0afd832
Compare
@labkode where should the binary data for an upload stream be stored? In the destination folder? In the shadow tree? in a |
should we also set "bigfilechunking" to v3.0 on the capabilities ? I'm aware that the TUS capability should be queried on specific endpoints, so I'm wondering if it makes sense to advertise the possibility of TUS at all on a global scope like the capabilities. |
@PVince81 imo exposing storage capabilities in a global capabilities endpoint no longer makes sense, because there is more than one storage at play. AFAICT storage capabilities in reva should be part of tdhe storage registry. Actually, it depends on what kind of capabilities we want to indicate. The sharing folder may have weird properties: it cannot be deleted or unshared, but you cannot upload folders there as well? Sometimes new folders appear. While all of this can be covered by permissions maybe a capability makes more sense Regarding chunking, for now I would expose tus as a new capability. It would allow clients to detect if they should even bother with checking the PROPFIND responses of collections for Regarding bigfilechunking ... no Idea what this is used for. in the code I commented that I guess it has to do with chunking v1. Android, ios and pyocclient seem to at least read it: https://github.com/search?q=org%3Aowncloud+bigfilechunking&type=Code |
Todo add tus to upload cmd
|
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
don't bother just go to #674 directly |
I'm trying to split up #661 into smaller pieces.
AFAICT this is the minimal useable patch:
out of scope
known issues
@PVince81 and @LukasHirt had this running after adding more CORS patches:
@labkode I'd like to get this in and work on reva cli commands to upload files so the patchset does not grow too big.