Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle metadata operations for shared folder #585

Merged
merged 10 commits into from
Mar 31, 2020

Conversation

labkode
Copy link
Member

@labkode labkode commented Mar 20, 2020

Fixes #495

Operations:

  • stat
  • list container
  • move
  • delete
  • mkdir
  • upload
  • download

Fixes also #611

ETAG generation for shared folder covered in:
#612

Allows to:

[gonzalhu@iota reva]$ reva ls /home/MyShares/
[gonzalhu@iota reva]$ reva share-update-received -state accepted 2a023c6b-1bd1-4284-a7d2-343c7ca092af
OK
[gonzalhu@iota reva]$ reva ls /home/MyShares/
photos
[gonzalhu@iota reva]$ reva ls /home/MyShares/photos/
Vigo
test

[gonzalhu@iota reva]$ reva mkdir /home/MyShares/photos/Ourense
[gonzalhu@iota reva]$ reva ls /home/MyShares/photos/
Ourense
Vigo

@labkode labkode requested a review from butonic March 31, 2020 12:40
@labkode
Copy link
Member Author

labkode commented Mar 31, 2020

@butonic can you review the current state, I prefer to merge and create another PR for the upload and download parts like that we can already mount/unmount access shares in the user home.

@labkode labkode changed the title [WIP] dereference resource info with type REFERENCE Handle metadata operations for shared folder Mar 31, 2020
@labkode labkode requested a review from refs March 31, 2020 12:45
@butonic
Copy link
Contributor

butonic commented Mar 31, 2020

@refs this is related to the /s/ prefix you were using for the public shares provider. Adding a GetPublicShares to the cs3 api seems to leak implementation details AFAICT ...

This PR hardcodes the /home path in the global namespace.

Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now. We have a different vision that uses spaces / treats shares as first class storages ... but we can discuss and pursue that regardless of this implementation.

@labkode labkode merged commit 331a367 into cs3org:master Mar 31, 2020
@labkode labkode deleted the virtual-ro-folder branch March 31, 2020 13:39
@labkode
Copy link
Member Author

labkode commented Mar 31, 2020

@butonic merged, I also add the upload/download methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eos: implement virtual shared folder
2 participants