Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OCM protocol #558

Merged
merged 31 commits into from
Mar 30, 2020
Merged

Implement OCM protocol #558

merged 31 commits into from
Mar 30, 2020

Conversation

ishank011
Copy link
Contributor

Migrating the OCM service from https://github.com/cernbox/ocmd to reva. Still a work in progress.

JarCz and others added 26 commits March 16, 2020 09:29
…to ocmd_migration

# Conflicts:
#	internal/http/services/ocmd/api.go
#	internal/http/services/ocmd/handlers.go
#	internal/http/services/ocmd/ocmd.go
#	internal/http/services/ocmd/shares.go
Register OCMD service in loader
Fix warning in listAllShares and getShare method
@labkode
Copy link
Member

labkode commented Mar 30, 2020

@ishank011 @JarCz what is the status of this PR? I propose we merge what is already here and add missing functionality later on.

@ishank011
Copy link
Contributor Author

@labkode from my side, the initial changes are complete. There are a few linting issues in @JarCz's code, and he is rewriting the share manager memory driver. So once that is done, I guess we can merge it

@labkode
Copy link
Member

labkode commented Mar 30, 2020

@ishank011 thanks, @JarCz what was the problem with the current memory manager?

@ishank011
Copy link
Contributor Author

@labkode he was fixing issues in the OCM share manager that we wrote.

@JarCz
Copy link
Contributor

JarCz commented Mar 30, 2020

@labkode I'm rewrite memory drive and wait to @ishank011 will merge my changes

@labkode labkode changed the title [WIP] Initial changes to migrate ocmd to reva Implement OCM protocol Mar 30, 2020
@labkode labkode merged commit 067fd10 into cs3org:master Mar 30, 2020
@ishank011 ishank011 deleted the ocmd_migration branch April 25, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants