Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement favourites for eos/grpc #4863

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Implement favourites for eos/grpc #4863

merged 4 commits into from
Oct 29, 2024

Conversation

ffurano
Copy link
Contributor

@ffurano ffurano commented Sep 23, 2024

Implement favourites for eos/grpc, following the logic of the eosbinary plugin

Copy link

update-docs bot commented Sep 23, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@glpatcern glpatcern self-requested a review October 8, 2024 07:00
@glpatcern glpatcern changed the title WIP - Implement favourites for eos/grpc Implement favourites for eos/grpc Oct 8, 2024
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, we need QA validation prior to merging

@glpatcern glpatcern merged commit 1d84cf0 into cs3org:master Oct 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants