Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM: Fix open driver #4790

Merged
merged 6 commits into from
Aug 5, 2024
Merged

OCM: Fix open driver #4790

merged 6 commits into from
Aug 5, 2024

Conversation

MahdiBaghbani
Copy link
Contributor

@MahdiBaghbani MahdiBaghbani commented Aug 4, 2024

The error happens because of an error probing OCM services at the remote server:
error doing request: Get \"revaowncloud1.docker/ocm-provider\": unsupported protocol scheme \"\"
since the provider domain doesn't have http:// or https://.

The changes in this PR add a scheme to the domain before the probing.

Fixes: #4791

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Mahdi! But see below for where to put the patch...

pkg/ocm/provider/authorizer/open/open.go Outdated Show resolved Hide resolved
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We have some failing tests for now in master, we'll need to look at them but it's independent from this change

@glpatcern glpatcern merged commit e636e4f into cs3org:master Aug 5, 2024
15 of 25 checks passed
@MahdiBaghbani MahdiBaghbani deleted the fix-ocm-open-driver branch August 5, 2024 07:34
glpatcern pushed a commit to glpatcern/reva that referenced this pull request Aug 30, 2024
* ocm: fixed domain not having a protocol scheme

* changelog

* changelog

* fix possible bug due to uppercase and lowercase string in domain

* lint: add space after // in comments

* Instead of modifying domain, use a new var endpoint
@glpatcern glpatcern added the OCM Open Cloud Mesh label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCM Open Cloud Mesh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCM: provider authorizer problems
2 participants