-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM: Fix open driver #4790
OCM: Fix open driver #4790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Mahdi! But see below for where to put the patch...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We have some failing tests for now in master
, we'll need to look at them but it's independent from this change
* ocm: fixed domain not having a protocol scheme * changelog * changelog * fix possible bug due to uppercase and lowercase string in domain * lint: add space after // in comments * Instead of modifying domain, use a new var endpoint
The error happens because of an error probing OCM services at the remote server:
error doing request: Get \"revaowncloud1.docker/ocm-provider\": unsupported protocol scheme \"\"
since the provider domain doesn't have
http://
orhttps://
.The changes in this PR add a scheme to the domain before the probing.
Fixes: #4791