Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing propagation to events #4110

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

ainmosni
Copy link

This adds a TraceParent field to the event envelope, adds context as
a parameter to the Publish function, adds functionality to extract
the traceparent from the context, and added a method to the envelope
to recover the tracing info and add it to the context.

This also passes context (empty if no context was present in the calling
function) to Publish wherever it is called.

This adds a TraceParent field to the event envelope, adds context as
a parameter to the Publish function, adds functionality to extract
the traceparent from the context, and added a method to the envelope
to recover the tracing info and add it to the context.

This also passes context (empty if no context was present in the calling
function) to Publish wherever it is called.
@ainmosni ainmosni requested review from a team, labkode and ishank011 as code owners August 10, 2023 08:34
@update-docs
Copy link

update-docs bot commented Aug 10, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ainmosni ainmosni requested a review from glpatcern as a code owner August 10, 2023 08:39
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kobergj kobergj merged commit 8d195c7 into cs3org:edge Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants