Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of an app provider for Overleaf #4084

Merged
merged 33 commits into from
Aug 25, 2023
Merged

Implementation of an app provider for Overleaf #4084

merged 33 commits into from
Aug 25, 2023

Conversation

abaldacchino
Copy link
Contributor

@abaldacchino abaldacchino commented Jul 27, 2023 •
edited by gmgigi96
Loading

This PR adds an app provider for Overleaf as a standalone http service.
The app provider currently consists of support for the export to Overleaf feature, which when called returns a URL to Overleaf that prompts Overleaf to download the appropriate resource making use of the Archiver service, and upload the files to a user's Overleaf account.

@abaldacchino abaldacchino marked this pull request as draft July 27, 2023 12:50
@abaldacchino abaldacchino changed the title Initial implementation of an app provider for Overleaf Implementation of an app provider for Overleaf Jul 27, 2023
@glpatcern glpatcern mentioned this pull request Jul 27, 2023
Merged
@abaldacchino abaldacchino force-pushed the overleaf branch 2 times, most recently from 569ef53 to 2df75ee Compare August 3, 2023 08:56
gmgigi96
gmgigi96 requested changes Aug 23, 2023
View reviewed changes
changelog/unreleased/overleaf.md Outdated Show resolved Hide resolved
examples/air/.air.toml Outdated Show resolved Hide resolved
examples/air/README.md Outdated Show resolved Hide resolved
internal/http/services/appprovider/appprovider.go Outdated Show resolved Hide resolved
internal/http/services/overleaf/overleaf.go Outdated Show resolved Hide resolved
internal/http/services/overleaf/overleaf.go Outdated Show resolved Hide resolved
internal/http/services/overleaf/overleaf.go Outdated Show resolved Hide resolved
internal/http/services/overleaf/overleaf.go Outdated Show resolved Hide resolved
pkg/eosclient/eosbinary/eosbinary.go Outdated Show resolved Hide resolved
internal/http/services/overleaf/overleaf.go Outdated Show resolved Hide resolved
@cs3org cs3org deleted a comment from update-docs bot Aug 23, 2023
@gmgigi96
Copy link
Member

This can be in the future an app provider, once we will define an Export and Import in the CS3APIs to handle cases like overleaf that do not allow any storage integration. Until that it's fine to keep it as a standalone http service.

@abaldacchino abaldacchino marked this pull request as ready for review August 25, 2023 13:59
@abaldacchino abaldacchino requested a review from a team as a code owner August 25, 2023 13:59
gmgigi96
gmgigi96 previously approved these changes Aug 25, 2023
View reviewed changes
gmgigi96
gmgigi96 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@gmgigi96 gmgigi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats @abaldacchino for your first merged PR in reva!

@gmgigi96 gmgigi96 merged commit d593983 into cs3org:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmgigi96 gmgigi96 gmgigi96 approved these changes

@labkode labkode Awaiting requested review from labkode

@wkloucek wkloucek Awaiting requested review from wkloucek

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abaldacchino @gmgigi96 @javfg @labkode