Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error checking code and fix sql script #4041

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Improve error checking code and fix sql script #4041

merged 1 commit into from
Jul 11, 2023

Conversation

javfg
Copy link
Contributor

@javfg javfg commented Jul 5, 2023

No description provided.

@javfg javfg force-pushed the notifications-cs3org branch from e7325fe to db8c18f Compare July 5, 2023 12:43
@gmgigi96 gmgigi96 marked this pull request as ready for review July 6, 2023 07:58
@gmgigi96 gmgigi96 requested review from labkode, gmgigi96, glpatcern and a team as code owners July 6, 2023 07:58
glpatcern
glpatcern requested changes Jul 6, 2023
View reviewed changes
pkg/notification/db_changes.sql Outdated Show resolved Hide resolved
@javfg javfg force-pushed the notifications-cs3org branch from db8c18f to 3c50b96 Compare July 10, 2023 08:37
@javfg javfg force-pushed the notifications-cs3org branch from 3c50b96 to c39625a Compare July 10, 2023 13:44
@glpatcern glpatcern self-requested a review July 10, 2023 15:58
glpatcern
glpatcern approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo the actual schema change on the oc_share we quickly discussed, this is so far OK

@gmgigi96 gmgigi96 merged commit b38215d into cs3org:master Jul 11, 2023
@glpatcern glpatcern mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

@gmgigi96 gmgigi96 gmgigi96 approved these changes

@labkode labkode Awaiting requested review from labkode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javfg @glpatcern @gmgigi96