-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert by-user-id index to messagepack #3995
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we force-refresh the index during startup? I'm just a little worried that spaces end up missing from the index when something goes wrong while updating the index. It's kinda self-healing when the according index is touched again, but esp. for the user cache this could take a while or not happen at all.
32e1b91
to
2babdce
Compare
@micbar yes, with the current implementation the first instance running the new code will start the migration which removes the old indexes. Older instances would thus not be able to list spaces anymore. Is that a problem? We could make it populate both indexes at first for a smoother upgrade, but I'm not sure the added complexity is justified. |
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.