Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert by-user-id index to messagepack #3995

Merged
merged 17 commits into from
Jul 4, 2023
Merged

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Jun 19, 2023

No description provided.

@update-docs
Copy link

update-docs bot commented Jun 19, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@aduffeck aduffeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we force-refresh the index during startup? I'm just a little worried that spaces end up missing from the index when something goes wrong while updating the index. It's kinda self-healing when the according index is touched again, but esp. for the user cache this could take a while or not happen at all.

pkg/storage/utils/decomposedfs/spaces.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/spaces.go Outdated Show resolved Hide resolved
@aduffeck aduffeck force-pushed the msgpack-index branch 2 times, most recently from 32e1b91 to 2babdce Compare June 20, 2023 13:09
@aduffeck aduffeck marked this pull request as ready for review June 21, 2023 08:45
@aduffeck aduffeck requested review from labkode, ishank011, glpatcern and a team as code owners June 21, 2023 08:45
@micbar
Copy link
Member

micbar commented Jun 21, 2023

@butonic @aduffeck Please describe any impact to existing installations.

Does the ocis instance need to be in "maintenance" mode?

@aduffeck
Copy link
Contributor

@micbar yes, with the current implementation the first instance running the new code will start the migration which removes the old indexes. Older instances would thus not be able to list spaces anymore.

Is that a problem? We could make it populate both indexes at first for a smoother upgrade, but I'm not sure the added complexity is justified.

Copy link
Member

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduffeck aduffeck merged commit ea9b5ba into cs3org:edge Jul 4, 2023
@aduffeck aduffeck deleted the msgpack-index branch July 4, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants