Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #3971 #3972

Merged
merged 1 commit into from
Jun 15, 2023
+7 −2
Merged

Fix for #3971 #3972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/patch-3971.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Fix for #3971

Fixed panic described in #3971

https://github.com/cs3org/reva/pull/3972
4 changes: 2 additions & 2 deletions pkg/ocm/share/repository/nextcloud/nextcloud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,10 +406,10 @@ func (sm *Manager) UpdateReceivedShare(ctx context.Context, user *userpb.User, s
}

func getUsername(user *userpb.User) string {
if len(user.Username) > 0 {
if user != nil && len(user.Username) > 0 {
return user.Username
}
if len(user.Id.OpaqueId) > 0 {
if user != nil && len(user.Id.OpaqueId) > 0 {
return user.Id.OpaqueId
}

Expand Down