Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-related compatibility fixes #3962

Merged
merged 12 commits into from
Jun 20, 2023
Merged

OCM-related compatibility fixes #3962

merged 12 commits into from
Jun 20, 2023

Conversation

glpatcern
Copy link
Member

@glpatcern glpatcern commented Jun 11, 2023

Following analysis of OC and NC code to access a remote share, we must expose paths and not full URIs on the /ocm-provider endpoint.

This is enough for OC but not for NC, where the access logic relies on other endpoints (see cs3org/OCM-API#70).

Also, we fix a lookup issue with apps over OCM, add a skeleton /ocm/notifications service, and update examples.

@glpatcern glpatcern requested review from labkode, gmgigi96 and a team as code owners June 11, 2023 04:59
@glpatcern glpatcern marked this pull request as draft June 11, 2023 05:00
@glpatcern glpatcern changed the title Use paths as opposed to full URIs in /ocm-provider Update /ocm-provider to be compatible with OC / NC Jun 12, 2023
@glpatcern glpatcern force-pushed the ocm-compat branch 11 times, most recently from 0b8f7b8 to cd57c71 Compare June 19, 2023 16:13
@glpatcern glpatcern changed the title Update /ocm-provider to be compatible with OC / NC Update /ocm-provider to be compatible with OC + other OCM compatibility fixes Jun 19, 2023
@glpatcern glpatcern changed the title Update /ocm-provider to be compatible with OC + other OCM compatibility fixes OCM-related compatibility fixes Jun 20, 2023
This service was introduced to test Nextcloud but it's not needed
@glpatcern glpatcern marked this pull request as ready for review June 20, 2023 10:10
@glpatcern glpatcern requested a review from wkloucek as a code owner June 20, 2023 10:10
pkg/app/provider/wopi/wopi.go Outdated Show resolved Hide resolved
@gmgigi96 gmgigi96 merged commit fe59f64 into cs3org:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants