Update and delete OCM shares #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmgigi96
force-pushed
the
update_delete_ocm_shares
branch
7 times, most recently
from
41e9850 to
37c0d32
Compare
gmgigi96
force-pushed
the
update_delete_ocm_shares
branch
from
7d2a028 to
de59686
Compare
gmgigi96
force-pushed
the
update_delete_ocm_shares
branch
from
cd0f379 to
6b44aa3
Compare
glpatcern
approved these changes
Jun 8, 2023
gmgigi96
added a commit
to gmgigi96/reva
that referenced
this pull request
Jun 28, 2023
* implemented DeleteRemoteUser * update state of received ocm share * fix cmd * removed old comment * add endpoint to delete accepted user * remove federated share * fix linter * accept/reject ocm recevied shares * update access methods in sql driver * inject time for unit tests * add unit tests for UpdateShare * removed tests for DeleteShare * update permissions of federated shares from ocs * update go-cs3apis * fix linter * add command in cli to remove an accepted user * update permissions of ocm share from cli * optimized query build when updating access methods * fix update ocm share in ocs * fix update received ocm share * return share id when accepting/reject ocm share * filter ocm shares by status * fix update received share * expose state of ocm share * set correct user type when deleting user * add share info when creating ocm share * disabled nextcloud unit test * add changelog * trigger pipeline * add header * fix rebase * fix linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following items:
Notification when updating/deleting an OCM share from the sender side is left as future work when the notification endpoint in the OCM specs is fully spelled out.