Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage drivers setup for datatx #3915

Merged
merged 2 commits into from
May 30, 2023

Conversation

redblom
Copy link
Contributor

@redblom redblom commented May 24, 2023

Change 'fixed' use of json files for datatx transfers/jobs to the storage driver setup that is common throughout reva.
Although some config change is needed, this PR does not change the datatx module behaviour.
Implements #3914

@redblom redblom requested review from labkode, gmgigi96, glpatcern and a team as code owners May 24, 2023 12:56
@redblom redblom force-pushed the datatx-persistency-drivers branch 3 times, most recently from 7185fc0 to 8cf8c68 Compare May 24, 2023 13:09
* Configurations for storage drivers

* Some clarification on cancelling transfers in the tutorial

* Remove transfer-create cli command, must use ocm-share-create instead
@redblom redblom force-pushed the datatx-persistency-drivers branch from 8cf8c68 to db8e258 Compare May 24, 2023 14:19
@redblom redblom changed the title Common storage drivers setup for datatx Storage drivers setup for datatx May 24, 2023
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks all good though I'm lost in the details. Could you maybe explain a bit more what's happening? Also, why is the transfer-create command gone now?

@redblom
Copy link
Contributor Author

redblom commented May 30, 2023

Could you maybe explain a bit more what's happening?

Previously the method of persisting data transfers and transfer jobs (ie. in json files) was set(fixed) in the code and couldn't be changed. Other modules use a storage drivers solution so the choice in db can be configured. Such configuration option is now also available for the datatx module with this change.
To configure one should specify 2 storage drivers, one for the datatx transfers (for the datatx service) and one for the transfer jobs (for the rclone driver). See file examples/datatx/datatx.toml.

Also, why is the transfer-create command gone now?

Creating a transfer is done via ocm-share-create with a -datax flag.

@glpatcern glpatcern merged commit 3a761e3 into cs3org:master May 30, 2023
gmgigi96 pushed a commit to gmgigi96/reva that referenced this pull request Jun 5, 2023
* * Datatx(transfers) and rclone(jobs) storage drivers setup

* Configurations for storage drivers

* Some clarification on cancelling transfers in the tutorial

* Remove transfer-create cli command, must use ocm-share-create instead

* Remove unnecessary logging

---------

Co-authored-by: Antoon P <antoon@redblom.com>
gmgigi96 pushed a commit to gmgigi96/reva that referenced this pull request Jun 28, 2023
* * Datatx(transfers) and rclone(jobs) storage drivers setup

* Configurations for storage drivers

* Some clarification on cancelling transfers in the tutorial

* Remove transfer-create cli command, must use ocm-share-create instead

* Remove unnecessary logging

---------

Co-authored-by: Antoon P <antoon@redblom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants