Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unshare for EOS storage driver #3794

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Fix unshare for EOS storage driver #3794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74f0df1
fix remove acl in eos storage driver
gmgigi96 Apr 14, 2023
ef9fbce
add changelog
gmgigi96 Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions changelog/unreleased/fix-unshare-eos.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Bugfix: Fix unshare for EOS storage driver

In the EOS storage driver, the remove acl operation was a no-op.
After removing a share, the recipient of the share was still able
to operate on the shared resource.
Now this has been fixed, removing correctly the ACL from the shared
resource.

https://github.com/cs3org/reva/pull/3794
1 change: 1 addition & 0 deletions pkg/eosclient/eosbinary/eosbinary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ func (c *Client) RemoveACL(ctx context.Context, auth, rootAuth eosclient.Authori
return err
}

a.Permissions = ""
sysACL := a.CitrineSerialize()
args := []string{"acl", "--sys"}
if finfo.IsDir {
Expand Down