Add description to public links + internal public links #3305
Conversation
gmgigi96
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
gmgigi96
changed the title
There was a problem hiding this comment.
One more field in DB hidden(boolean) so the normal shares queries from the web will always be on type: select * from oc_share where type = public link and hidden=false, today we have codimd, but tomorrow we may have other apps and then we would need to touch again the normal query (not good).
|
As just discussed with Gianmaria: let's call the extra field |
|
The hidden in the db requires to modify the cs3apis, as now is not anymore cernbox specific. As we discussed with @glpatcern we could add a bool field named Internal, to specify that that public link is used for internal purpose (in the context of an application, for example), and so because was not created by the user, is hidden in the list. What do you think? |
|
Go ahead! |
gmgigi96
force-pushed
the
publiclinks-tag
branch
2 times, most recently
from
fc8f6b4 to
192974e
Compare
gmgigi96
force-pushed
the
publiclinks-tag
branch
from
192974e to
67609f8
Compare
gmgigi96
changed the title
* use update go cs3apis (temporary) * Add description in db public link * add description in the sql driver * update go cs3apis * add description in xml response for public links * create and update a public link with description * hide tags by description in sql driver * update cs3apis * add description during creation * updated cli cmd for public share description * fix linting * fix query to hide tags * add changelog * add option to hide public shares * updated go-cs3apis
* use update go cs3apis (temporary) * Add description in db public link * add description in the sql driver * update go cs3apis * add description in xml response for public links * create and update a public link with description * hide tags by description in sql driver * update cs3apis * add description during creation * updated cli cmd for public share description * fix linting * fix query to hide tags * add changelog * add option to hide public shares * updated go-cs3apis
* use update go cs3apis (temporary) * Add description in db public link * add description in the sql driver * update go cs3apis * add description in xml response for public links * create and update a public link with description * hide tags by description in sql driver * update cs3apis * add description during creation * updated cli cmd for public share description * fix linting * fix query to hide tags * add changelog * add option to hide public shares * updated go-cs3apis
* use update go cs3apis (temporary) * Add description in db public link * add description in the sql driver * update go cs3apis * add description in xml response for public links * create and update a public link with description * hide tags by description in sql driver * update cs3apis * add description during creation * updated cli cmd for public share description * fix linting * fix query to hide tags * add changelog * add option to hide public shares * updated go-cs3apis
This PR adds the possibility to set a description to a public link, allowing an user to describe the usefulness of the public link.
It also adds an option to set the public links for internal usage (for example for being using by apps). When a public link is internal, this will not be exposed in the list of public links.