Allow http service to expose prefixes containing slashes (/) #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
labkode
changed the title
labkode
previously approved these changes
Jul 12, 2022
|
@labkode I will fix the code to pass the tests |
|
@gmgigi96 the thing is I don't know why they failed ... |
I think I got it. Before the handler was called with the URL containing only the tail part of the original URL request, and this is what the different http services are expecting. |
labkode
approved these changes
Jul 13, 2022
gmgigi96
added a commit
to cernbox/reva
that referenced
this pull request
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to expose services under URLs like
api/v1/mystuffrather than just onapi