Fix 0 byte uploads #2998
Merged
Fix 0 byte uploads #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduffeck
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
There are still many failures in the CI. The code looks good but I don't want to approve as long as the CI fails. |
aduffeck
force-pushed
the
fix-0-byte-uploads
branch
from
3e14475 to
d7faa2d
Compare
aduffeck
force-pushed
the
fix-0-byte-uploads
branch
from
d7faa2d to
b9cc0b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with 0-byte uploads by using
TouchFileinstead of going through TUS (decomposedfs and owncloudsql storage drivers only for now).Fixes owncloud/ocis#3154