Fix target uri for webdav prefix for datatx #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redblom
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
wkloucek
reviewed
Jun 15, 2022
glpatcern
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Approving on the basis of the discussions in gitter:
This change only touches the transfer type shares flow in the
UpdateReceivedOCMSharefunction of the OCM Share Provider.
As a matter of fact, the OCM test suite is able to test the OCM workflow and should be able to pick up regressions.
|
Apart from @redblom's manual testing I also quickly tested it with the OCM test suite and didn't encounter any problems. 👍 |
|
Excellent, thanks @michielbdejong 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a webdav prefix is used it appears in both host and name parameter of the target uri for data transfer. This PR fixes that.
The resulting target uri should be similar to:
http://...token...@reva.eu/prefix/?name=remote.php/webdav/home/...