Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decomposedfs allow arbitrary length spaceid #2854

Merged
merged 9 commits into from
May 11, 2022
Merged

Decomposedfs allow arbitrary length spaceid #2854

merged 9 commits into from
May 11, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented May 11, 2022

The decomposedfs no longer panics when trying to look up spaces with a non uuid length id.

butonic added 4 commits May 11, 2022 09:14
@butonic
add failing test
f85fce6 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
fix test
a2c140e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
use table test
37ca6eb 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
add changelog
d5d675b 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested review from a team, labkode, ishank011 and glpatcern as code owners May 11, 2022 10:07
@butonic
add inline docs
db7607b 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested a review from aduffeck May 11, 2022 10:10
@butonic butonic mentioned this pull request May 11, 2022
Closed
butonic added 2 commits May 11, 2022 10:19
@butonic
unfocus test
6b8165e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
actually use random temp dir
9e80395 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
kobergj
kobergj requested changes May 11, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@butonic butonic requested a review from kobergj May 11, 2022 12:23
@butonic
go mod tidy
c9f3f92 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the decomposedfs-allow-arbitrary-length-spaceid branch from 2c94acd to c9f3f92 Compare May 11, 2022 12:26
C0rby
C0rby approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick.

pkg/storage/utils/decomposedfs/spaces.go Outdated Show resolved Hide resolved
@butonic @C0rby
Update pkg/storage/utils/decomposedfs/spaces.go
be0ecc7 
Co-authored-by: David Christofas <dchristofas@posteo.de>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic merged commit 9205e84 into cs3org:edge May 11, 2022
@butonic butonic deleted the decomposedfs-allow-arbitrary-length-spaceid branch May 11, 2022 14:04
@C0rby C0rby mentioned this pull request May 11, 2022
Merged
@wkloucek wkloucek mentioned this pull request May 17, 2022
Closed
@micbar micbar mentioned this pull request May 25, 2022
Closed
25 tasks
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@kobergj kobergj kobergj approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

@aduffeck aduffeck Awaiting requested review from aduffeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butonic @C0rby @kobergj