Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] bump core commit id to the latest upto 2022-05-10 #2849

Merged
merged 2 commits into from
May 11, 2022

Conversation

kiranparajuli589
Copy link
Contributor

Description

  • bump core commit id to the latest up to 2022-05-10

Related Issue

Signed-off-by: Kiran Parajuli kiranparajuli589@gmail.com

@kiranparajuli589
Copy link
Contributor Author

why changelog is expected for this type of pr 🤔?
https://drone.cernbox.cern.ch/cs3org/reva/7030/1/2

@phil-davis
Copy link
Contributor

phil-davis commented May 10, 2022

why changelog is expected for this type of pr thinking? https://drone.cernbox.cern.ch/cs3org/reva/7030/1/2

It is not supposed to do that - "tests-only" in the PR title should stop it from requiring a changelog.

https://drone.cernbox.cern.ch/cs3org/reva/7031/1/2

2022/05/10 10:07:33 Skipping changelog check for tag: [tests-only]

Try forcing a rebase...

@phil-davis
Copy link
Contributor

// Case-insensitive list of PRs for which changelog enforcement needs to be skipped
var skipTags = []string{"[tests-only]", "[build-deps]", "[docs-only]"}
		if strings.HasPrefix(prTitle, tag) {
			log.Print("Skipping changelog check for tag: " + tag)
			return true
		}

IMO you have to put [tests-only] at the very start of the PR title.

@kiranparajuli589 kiranparajuli589 force-pushed the bump-core-commit-id-2022-05-10 branch from d1284e0 to 7f4c459 Compare May 10, 2022 10:50
@kiranparajuli589 kiranparajuli589 changed the title [full-ci][tests-only] bump core commit id to the latest upto 2022-05-10 [tests-only][full-ci] bump core commit id to the latest upto 2022-05-10 May 10, 2022
@kiranparajuli589 kiranparajuli589 force-pushed the bump-core-commit-id-2022-05-10 branch from 7f4c459 to b0e41d7 Compare May 10, 2022 10:51
Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
@kiranparajuli589 kiranparajuli589 force-pushed the bump-core-commit-id-2022-05-10 branch from b0e41d7 to 2478f9b Compare May 11, 2022 04:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants