Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make hard-coded HTTP "insecure" options configurable #2775

Merged
merged 4 commits into from
May 17, 2022
Merged

fix: make hard-coded HTTP "insecure" options configurable #2775

merged 4 commits into from
May 17, 2022

Conversation

amalthundiyil
Copy link
Contributor

re #2216

ishank011
ishank011 reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amal-thundiyil, I left a couple of comments

cmd/reva/main.go Outdated Show resolved Hide resolved
cmd/reva/main.go Outdated Show resolved Hide resolved
@amalthundiyil amalthundiyil requested a review from ishank011 May 3, 2022 04:18
ishank011
ishank011 reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amal-thundiyil. One minor comment, we can merge then

cmd/reva/download.go Outdated Show resolved Hide resolved
ishank011
ishank011 reviewed May 3, 2022
View reviewed changes
cmd/reva/download.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amalthundiyil amalthundiyil changed the title Make hard-coded HTTP "insecure" options configurable fix: make hard-coded HTTP "insecure" options configurable May 8, 2022
ishank011
ishank011 approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ishank011 ishank011 merged commit 627d0d3 into cs3org:master May 17, 2022
@amalthundiyil amalthundiyil deleted the options branch May 17, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishank011 ishank011 ishank011 approved these changes

@labkode labkode Awaiting requested review from labkode

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amalthundiyil @ishank011