Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Bump core commit id 20220315 #2638

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Mar 15, 2022

Issue owncloud/QA#731

I added the new "product" data item into the capabilities, version and status responses. That will keep those compatible with the new expected responses.

@phil-davis phil-davis self-assigned this Mar 15, 2022
@phil-davis phil-davis force-pushed the bump-core-commit-id-20220315 branch 2 times, most recently from 9910cb4 to 539176d Compare March 15, 2022 22:26
@phil-davis phil-davis force-pushed the bump-core-commit-id-20220315 branch from 3ced311 to 06f1d3a Compare March 16, 2022 04:23
@phil-davis phil-davis marked this pull request as ready for review March 16, 2022 04:24
@phil-davis phil-davis requested review from a team, labkode, ishank011 and glpatcern as code owners March 16, 2022 04:24
@phil-davis phil-davis merged commit 9911567 into cs3org:edge Mar 16, 2022
@phil-davis phil-davis deleted the bump-core-commit-id-20220315 branch March 16, 2022 05:00
@phil-davis
Copy link
Contributor Author

@kulmann I added the "product" data items to the various capabilities version, core, status responses here - hardcoded in the same way as the other existing values. I also enhanced the test code in core so that can request a capabilities response without relying on the "admin" account. The test scenarios for capabilities (status and version sections) and for the status.php end-point now pass here in reva.

So you can make the version, product etc responses more flexible (e.g. to report a "real" version number...) and there are test scenarios that should keep passing. The tests check that values in the capabilities response match with values in the status.php response, that major/minor/micro version numbers are actual numbers, and that the version string correctly starts with the numbers from major.minor.micro. So if new flexible code changes version numbers, product name etc, then the tests will keep passing as long as all the endpoints report consistent values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants