-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] Update composer.json #2539
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Note: going down from PHP 7.4 to min 7.2 is OK. But in practice, I think that the test code has has PHP 7.3 and/or 7.4 parameter and return type declarations etc added to it. So the test code might not actually run with PHP 7.2. |
I don't want to go down, i just took the composer.json from the edge branch and modified it. |
fixed |
I am surprised. master gets merged into edge every few weeks, so |
@ishank011 @labkode this should be merged to master to prevent collisions with the |
@ishank011 @labkode can we please have this merged? |
Description
Fixes a naming collision. The go modules try to use the vendor folder from the test php deps.
Solution: Change the name