Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for pkg/auth/manager/(demo|json) #214

Merged
merged 2 commits into from
Aug 23, 2019
Merged

tests for pkg/auth/manager/(demo|json) #214

merged 2 commits into from
Aug 23, 2019

Conversation

unixlab
Copy link
Contributor

@unixlab unixlab commented Aug 23, 2019

After pkg/user/manager/ now tests for pkg/auth/manager/demo/

$ go test -cover github.com/cs3org/reva/pkg/auth/manager/demo
ok  	github.com/cs3org/reva/pkg/auth/manager/demo	0.003s	coverage: 100.0% of statements

and pkg/auth/manager/json/

$ go test -cover github.com/cs3org/reva/pkg/auth/manager/json
ok  	github.com/cs3org/reva/pkg/auth/manager/json	0.004s	coverage: 100.0% of statements

@unixlab unixlab requested a review from labkode as a code owner August 23, 2019 14:19
@codecov-io
Copy link

Codecov Report

Merging #214 into master will increase coverage by 1.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   93.05%   94.65%   +1.59%     
==========================================
  Files           4        6       +2     
  Lines         144      187      +43     
==========================================
+ Hits          134      177      +43     
  Misses          5        5              
  Partials        5        5
Impacted Files Coverage Δ
pkg/auth/manager/demo/demo.go 100% <0%> (ø)
pkg/auth/manager/json/json.go 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2ed56...6b5ebeb. Read the comment docs.

@labkode
Copy link
Member

labkode commented Aug 23, 2019

Thanks a lot for this effort!

@labkode labkode merged commit 6c3396d into cs3org:master Aug 23, 2019
@unixlab unixlab deleted the add-tests-pkg-auth-manager branch August 24, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants