AppProvider: report errors from WOPI and return base64-encoded fileids #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
force-pushed
the
app-errors
branch
3 times, most recently
from
d370af7 to
04f4873
Compare
glpatcern
changed the title
glpatcern
force-pushed
the
app-errors
branch
2 times, most recently
from
f4076d5 to
db194e9
Compare
glpatcern
force-pushed
the
app-errors
branch
3 times, most recently
from
cf8c615 to
ba625b2
Compare
ishank011
reviewed
Sep 24, 2021
glpatcern
force-pushed
the
app-errors
branch
2 times, most recently
from
8af8e6d to
c895900
Compare
glpatcern
force-pushed
the
app-errors
branch
from
c895900 to
ac3da0d
Compare
ishank011
approved these changes
Sep 27, 2021
glpatcern
added a commit
to glpatcern/reva
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to log and report back from the AppProvider's
/app/opento the UI any error reported by the WOPI server.It also includes another fix in the AppProvider to return a base64-encoded fileid on
/app/new.