Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fmt.Print statement from decomposedfs #1988

Closed
wants to merge 2 commits into from
Closed

remove fmt.Print statement from decomposedfs #1988

wants to merge 2 commits into from

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Aug 12, 2021

@update-docs
Copy link

update-docs bot commented Aug 12, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek changed the title remove prints for spaces remove fmt.Print statement from decomposedfs Aug 12, 2021
@wkloucek wkloucek requested a review from butonic August 12, 2021 10:31
@wkloucek
Copy link
Contributor Author

@butonic what should we do here? There is no logging available. Can we just remove the Print statements?

@butonic
Copy link
Contributor

butonic commented Aug 12, 2021

The correct implementation would check

  1. if the symlink already exists
  2. if it points to the correct node (if not overwrite the existing symlink)
  3. if the symlink cannot be created ... log an error ... hah the trick is
    logger.New().Warn().Msg("userfilter is deprecated, use a loginfilter like `(&(objectclass=posixAccount)(|(cn={{login}}))(mail={{login}}))`")

it will use the default log configuration, but at least it is a structured log message.

and the left over case really is an error the admin should tackle, because the correct symlink cannot be created.

@wkloucek
Copy link
Contributor Author

The correct implementation would check

  1. if the symlink already exists
  2. if it points to the correct node (if not overwrite the existing symlink)
  3. if the symlink cannot be created ... log an error ... hah the trick is
    logger.New().Warn().Msg("userfilter is deprecated, use a loginfilter like `(&(objectclass=posixAccount)(|(cn={{login}}))(mail={{login}}))`")

it will use the default log configuration, but at least it is a structured log message.

and the left over case really is an error the admin should tackle, because the correct symlink cannot be created.

Doesn't sound like just replacing the Print with a Log. Could you please take care?

@butonic
Copy link
Contributor

butonic commented Aug 13, 2021

closing in favor of #1992

@butonic butonic closed this Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

could not create symlink for 'personal' space
2 participants