Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] introduce /dav/spaces endpoint && CS3 list spaces implementation (ocis driver only) #1776

Closed
wants to merge 1 commit into from
Closed

[WIP] introduce /dav/spaces endpoint && CS3 list spaces implementation (ocis driver only) #1776

wants to merge 1 commit into from

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Jun 8, 2021

rebase of #1678 on top of the new-references branch

@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2021

This pull request introduces 3 alerts when merging 61d19c1 into d85c072 - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@C0rby C0rby force-pushed the list-spaces-with-new-references branch from 4a3f5f9 to 8b4637c Compare June 9, 2021 10:09
@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request introduces 3 alerts when merging 8b4637c into 9de782f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@butonic butonic mentioned this pull request Jun 9, 2021
Closed
2 tasks
@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request introduces 3 alerts when merging 931c7f1 into 9de782f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request introduces 3 alerts when merging e189138 into 9de782f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request introduces 3 alerts when merging 947cfb6 into 9de782f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request introduces 3 alerts when merging 9cbde91 into 9de782f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request introduces 3 alerts when merging c59ce8e into 9de782f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request introduces 3 alerts when merging b5c8ecd into 9de782f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request introduces 3 alerts when merging 6b190af into 9de782f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request introduces 3 alerts when merging 6647f1d into 9de782f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2021

This pull request introduces 3 alerts when merging e95be4a into 9de782f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2021

This pull request introduces 3 alerts when merging bf15aeb into a9556a3 - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@butonic butonic force-pushed the list-spaces-with-new-references branch from bf15aeb to 2b43c59 Compare June 14, 2021 09:03
@lgtm-com
Copy link

lgtm-com bot commented Jun 14, 2021

This pull request introduces 3 alerts when merging 2b43c59 into 0541645 - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@butonic butonic force-pushed the list-spaces-with-new-references branch from 2b43c59 to 5997fa9 Compare June 14, 2021 10:15
@lgtm-com
Copy link

lgtm-com bot commented Jun 14, 2021

This pull request introduces 3 alerts when merging 5997fa9 into 0541645 - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@butonic butonic force-pushed the list-spaces-with-new-references branch from 5997fa9 to bb23e7b Compare June 15, 2021 14:03
@lgtm-com
Copy link

lgtm-com bot commented Jun 15, 2021

This pull request introduces 3 alerts when merging bb23e7b into 07adb3f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2021

This pull request introduces 3 alerts when merging fcfdd53 into 07adb3f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2021

This pull request introduces 3 alerts when merging c7da815 into 07adb3f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2021

This pull request introduces 3 alerts when merging 14827d9 into 692f38f - view on LGTM.com

new alerts:

  • 3 for Uncontrolled data used in path expression

@butonic butonic force-pushed the list-spaces-with-new-references branch from 14827d9 to 51c336e Compare June 17, 2021 20:04
@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2021

This pull request introduces 1 alert and fixes 18 when merging 51c336e into 9740eed - view on LGTM.com

new alerts:

  • 1 for Uncontrolled data used in path expression

fixed alerts:

  • 18 for Uncontrolled data used in path expression

@butonic
parent 692f38f
b222d4d 
author Jörn Friedrich Dreyer <jfd@butonic.de> 1623945204 +0200
committer Jörn Friedrich Dreyer <jfd@butonic.de> 1623958936 +0000

switch references (cs3org#1721)

Co-authored-by: A.Unger <zyxancf@gmail.com>
Co-authored-by: David Christofas <dchristofas@owncloud.com>

rebase

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

fix nil

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

update changelog

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

add storage provider list spaces interface

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

add stubs

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

initial ocis implementation for list storage spaces

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

minor fixes

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

add thoughts on proper spaces persistence layout

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

Initial spaces implementation.

Signed-off-by: Klaas Freitag <kfreitag@owncloud.com>

more spaces work

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

filter spaces based on permissions, return name

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

resolve linter issues

implement storage space support into the storageprovider

Co-authored-by: Jörn Friedrich Dreyer <jfd@butonic.de>

fix dav spaces href

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

GET preparations

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

WIP: spaces datatx

Add spaces.go

distinguish spaces/simple datatx

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

make GET work for spaces

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

MKCol implementation for spaces WIP

refactor CreateDir

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

make MKCOL work for spaces

implement delete for the spaces api

fix: unwrap the requested reference before using it further

implement MOVE for spaces

simplify check if request body is empty

setup constants for webdav verbs

fix listcontainers for spaces references

implement PROPPATCH for spaces

implement COPY for spaces

add cases for lock, unlock and report for spaces

implement PUT for spaces

implement POST for spaces

implement HEAD for spaces

clean up and deduplicate webdav HEAD code

clean up and deduplicate webdav DELETE code

clean up and deduplicate webdav GET code

clean up and deduplicate webdav PROPFIND code

clean up and deduplicate webdav MKCOL code

clean up and deduplicate webdav MOVE code

clean up and deduplicate webdav PROPPATCH code

clean up and deduplicate webdav COPY code

clean up and deduplicate webdav TUS POST code

clean up and deduplicate webdav PUT code

try fixing tests

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

fix path checks before calling WalkPath

update the owncloudsql storage driver

fix spaceid handling

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

fix linter issues

fix CreateDir in the owncloud storage driver

fix non space path handling

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

allow creating empty files

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

no longer hardcode storageid in the driver

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

decomposedfs: create storage spaces

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

Id -> ID

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

move change-references changelog to unreleased

add spaces changelog

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

add grant test for spaces

goimports

update to embedded reference

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

relative references should only return the basename

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

do not show shared resources as spaces for owners

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

make sure the usage of user provides paths is secure

list spaces from all providers

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the list-spaces-with-new-references branch from 51c336e to b222d4d Compare June 17, 2021 20:34
@butonic butonic mentioned this pull request Jun 17, 2021
Closed
10 tasks
@lgtm-com
Copy link

lgtm-com bot commented Jun 17, 2021

This pull request introduces 1 alert and fixes 18 when merging b222d4d into 9740eed - view on LGTM.com

new alerts:

  • 1 for Uncontrolled data used in path expression

fixed alerts:

  • 18 for Uncontrolled data used in path expression

@butonic butonic mentioned this pull request Jun 18, 2021
Merged
@butonic butonic mentioned this pull request Jun 18, 2021
Merged
3 tasks
@butonic
Copy link
Contributor Author

butonic commented Jun 21, 2021

supersedted by #1802 and #1803

@butonic butonic closed this Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern will be requested when the pull request is marked ready for review glpatcern is a code owner

@diocas diocas Awaiting requested review from diocas diocas will be requested when the pull request is marked ready for review diocas is a code owner

@jessegeens jessegeens Awaiting requested review from jessegeens jessegeens will be requested when the pull request is marked ready for review jessegeens is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@butonic