Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Fix linter issues #1556

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Conversation

aduffeck
Copy link
Contributor

No description provided.

@update-docs
Copy link

update-docs bot commented Mar 16, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@aduffeck aduffeck changed the title [test-only] Fix linter issues [tests-only] Fix linter issues Mar 16, 2021
@aduffeck aduffeck marked this pull request as ready for review March 16, 2021 13:25
@aduffeck aduffeck requested a review from labkode as a code owner March 16, 2021 13:25
@ishank011 ishank011 merged commit dcb0d12 into cs3org:master Mar 16, 2021
@wkloucek
Copy link
Contributor

@aduffeck @ishank011 what was the reason that an update to Go 1.16 was needed?

@wkloucek wkloucek mentioned this pull request Mar 23, 2021
9 tasks
@ishank011
Copy link
Contributor

@wkloucek We wanted to embed a binary using the go1.16 package #1505

@wkloucek
Copy link
Contributor

Ah I see, its introduced by importing https://github.com/sciencemesh/meshdirectory-web/blob/main/meshdirectory_web.go

ffurano pushed a commit to ffurano/reva that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants