Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Categorize expected-failures-on-OWNCLOUD-storage #1426

Merged
merged 4 commits into from
Jan 29, 2021
Merged

[tests-only] Categorize expected-failures-on-OWNCLOUD-storage #1426

merged 4 commits into from
Jan 29, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 29, 2021

So that it is in the same format as expected-failures-on-OCIS-storage that was done in PR #1424

  1. copy the "new format" expected-failures-on-OCIS-storage to expected-failures-on-OWNCLOUD-storage
  2. fix some typos in both files
  3. Remove some duplicates from expected-failures-on-OCIS-storage (that I randomly noticed)
  4. Adjust expected-failures-on-OWNCLOUD-storage

The diffs in the 4th commit give a good idea of the things that are different between OCIS and OWNCLOUD storage.

@phil-davis phil-davis marked this pull request as ready for review January 29, 2021 06:09
@phil-davis phil-davis requested a review from labkode as a code owner January 29, 2021 06:09
@phil-davis phil-davis self-assigned this Jan 29, 2021
@phil-davis
Copy link
Contributor Author

@labkode @ishank011 @butonic ready for review

Copy link
Contributor

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@ishank011 ishank011 merged commit 7ee4cec into cs3org:master Jan 29, 2021
@phil-davis phil-davis deleted the categorize-expected-failures-owncloud branch January 29, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants