Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Bump commit id for API tests #1407

Merged
merged 4 commits into from
Jan 20, 2021
Merged

[tests-only] Bump commit id for API tests #1407

merged 4 commits into from
Jan 20, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 19, 2021

  1. bump commit id and adjust expected-failures for the regular changes in expected-failures.
  2. Rename expected-failures files to .md - the core API tests now have the expected-failures list in markdown format
  3. Copy expected-failures markdown files from the ones that are being applied in owncloud/ocis
  4. Bump the core commit id to the latest and adjust the expected-failures md files for what passes and fails in cs3org/reva (mostly removing entries from exxpected-failures because more scenarios pass here in cs3org/reva - and they will start passing in owncloud/ocis when the latest reva is updated into owncloud/ocis)

IljaN
IljaN previously approved these changes Jan 19, 2021
@phil-davis phil-davis marked this pull request as ready for review January 20, 2021 05:02
@phil-davis phil-davis requested a review from labkode as a code owner January 20, 2021 05:02
@phil-davis phil-davis requested review from ishank011 and IljaN January 20, 2021 05:02
@phil-davis
Copy link
Contributor Author

phil-davis commented Jan 20, 2021

@labkode @ishank011 there are big diffs here, but it is "just" the re-formatting of the long expected-failures files. I have verified that the expected-failures files do get processed. CI passes here. So you do not have to review every line of the expected-failures files!

Ready for review and approval.

@ishank011 ishank011 merged commit a7bf52b into cs3org:master Jan 20, 2021
@phil-davis phil-davis deleted the bump-commit-id-20210119 branch January 20, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants