ocis driver: access shares, trash, revisions, metadata #1155

butonic · 2020-09-09T15:14:00Z

continuation of #559

PVince81

sharing code commit looks fine so far, see a few comments

pkg/storage/fs/ocis/ocis.go

pkg/storage/fs/ocis/path.go

pkg/storage/fs/ocis/tree.go

PVince81 · 2020-09-09T15:41:14Z

pkg/storage/fs/ocis/tree.go

+		return
+	}
+	for err == nil && node.ID != root.ID { // TODO propagate up to where?
+		if err := xattr.Set(filepath.Join(t.pw.Root, "nodes", node.ID), "user.ocis.etag", []byte(etag)); err != nil {


using the same etag value for all parent members ?

pkg/storage/fs/ocis/ocis.go

pkg/storage/fs/ocis/path.go

PVince81 · 2020-09-10T07:11:33Z

👍 for the latest refactorings based on my comments.

please check the linter

PVince81

Looks fine to me except for the attr name, feel free to change

pkg/storage/fs/ocis/ocis.go

pkg/storage/fs/ocis/recycle.go

butonic · 2020-09-10T20:57:34Z

-> running `props':
 0. init.................. pass
 1. begin................. pass
 2. propfind_invalid...... pass
 3. propfind_invalid2..... pass
 4. propfind_d0........... pass
 5. propinit.............. pass
 6. propset............... pass
 7. propget............... pass
 8. propextended.......... pass
 9. propmove.............. pass
10. propget............... pass
11. propdeletes........... pass
12. propget............... pass
13. propreplace........... FAIL (PROPPATCH on `/remote.php/dav/files/4c510ada-c86b-4815-8820-42cdf82c3d51/litmus/prop2': 500 Internal Server Error)
14. propget............... FAIL (Property {http://example.com/neon/litmus/}prop9 had value value9, expected newvalue9)
15. propnullns............ pass
16. propget............... pass
17. propremoveset......... FAIL (PROPPATCH remove then set)
18. propget............... FAIL (No value given for property {http://example.com/neon/litmus/}removeset)
19. propsetremove......... pass
20. propget............... pass
21. propvalnspace......... pass
22. propwformed........... pass
23. propinit.............. pass
24. propmanyns............ pass
25. propget............... pass
26. propcleanup........... pass
27. finish................ pass
<- summary for `props': of 28 tests run: 24 passed, 4 failed. 85.7%

PVince81

Latest commits for trash, restore version and download versions look fine

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* initial version Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * introduce NodeInfo Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * fix metadata normalization Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * stick to github.com/google/uuid Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * simpler layout, parentid and name as ext attr Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * manually adding mimetypes is no longer needed Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * rename Wrap to NodeFrom* Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * refactor node implementation Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * fix delete and overwrite Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * initial sharing, store owner as ext attr, fix NewNode Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * separate files for metadada, revisions and recycle Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * list revisions Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * refactor and use ACE package Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * refactor node api Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * add license headers Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * add changelog Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * remove duplicate docs (moved to ace.go) Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * make linter happy Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * ocis: access shares Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * refactorings Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * fix upload Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * implement commit trash Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * implement RestoreRecycleItem Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * complete trash Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * address trash review Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * restore revision Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * download revision Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * fix litmus 409me Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * set and unset metadata Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> * read metadata Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

butonic requested a review from labkode as a code owner September 9, 2020 15:14

PVince81 reviewed Sep 9, 2020

View reviewed changes

PVince81 mentioned this pull request Sep 10, 2020

Reva ocis storage owncloud/ocis-reva#466

Merged

3 tasks

butonic force-pushed the ocis-sharing branch from 8b67914 to 3db04b9 Compare September 10, 2020 09:29

butonic changed the title ~~[WIP] ocis driver: access shares~~ [WIP] ocis driver: access shares, trash Sep 10, 2020

PVince81 previously approved these changes Sep 10, 2020

View reviewed changes

pkg/storage/fs/ocis/ocis.go Outdated Show resolved Hide resolved

pkg/storage/fs/ocis/recycle.go Show resolved Hide resolved

butonic dismissed PVince81’s stale review via a65875a September 10, 2020 14:38

PVince81 previously approved these changes Sep 11, 2020

View reviewed changes

butonic changed the title ~~[WIP] ocis driver: access shares, trash~~ ocis driver: access shares, trash Sep 11, 2020

butonic changed the title ~~ocis driver: access shares, trash~~ ocis driver: access shares, trash, revisions, metadata Sep 11, 2020

butonic mentioned this pull request Sep 11, 2020

ocis storage driver #559

Closed

14 tasks

butonic added 17 commits September 11, 2020 12:38

initial version

00d6ed6

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

introduce NodeInfo

103f092

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

fix metadata normalization

5692fde

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

stick to github.com/google/uuid

f1b79b3

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

simpler layout, parentid and name as ext attr

b81ade5

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

manually adding mimetypes is no longer needed

2fc669a

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

rename Wrap to NodeFrom*

82d6ccb

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

refactor node implementation

5392e9c

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

fix delete and overwrite

e292249

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

initial sharing, store owner as ext attr, fix NewNode

7c3ab8f

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

separate files for metadada, revisions and recycle

7690089

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

list revisions

773284d

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

refactor and use ACE package

9cb544a

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

refactor node api

eb64854

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

add license headers

84e46b9

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

add changelog

d6db879

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

remove duplicate docs (moved to ace.go)

67b46ba

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

butonic added 13 commits September 11, 2020 12:38

make linter happy

a5b743c

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

ocis: access shares

0a4f19b

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

refactorings

f892cc7

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

fix upload

238a3ef

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

implement commit trash

3bc642d

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

implement RestoreRecycleItem

31ed3ef

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

complete trash

ff2adf2

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

address trash review

a7257a1

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

restore revision

bde6b64

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

download revision

c075a0a

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

fix litmus 409me

6244eb7

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

set and unset metadata

16cb048

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

read metadata

a03af64

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

butonic dismissed PVince81’s stale review via a03af64 September 11, 2020 10:38

butonic force-pushed the ocis-sharing branch from 164632b to a03af64 Compare September 11, 2020 10:38

SamuAlfageme merged commit 51649e3 into cs3org:master Sep 11, 2020

micbar mentioned this pull request Sep 14, 2020

Prototyping for oCIS Storage Driver owncloud/product#119

Closed

2 tasks

exalate-issue-sync bot mentioned this pull request Sep 14, 2020

Test Etag propagation for oCIS storage owncloud/product#144

Closed

17 tasks

phil-davis mentioned this pull request Sep 14, 2020

[Tests-Only] Run litmus CI for both owncloud and ocis storage #1166

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ocis driver: access shares, trash, revisions, metadata #1155

ocis driver: access shares, trash, revisions, metadata #1155

butonic commented Sep 9, 2020

PVince81 left a comment

PVince81 Sep 9, 2020

PVince81 commented Sep 10, 2020

PVince81 left a comment

butonic commented Sep 10, 2020

PVince81 left a comment

ocis driver: access shares, trash, revisions, metadata #1155

ocis driver: access shares, trash, revisions, metadata #1155

Conversation

butonic commented Sep 9, 2020

PVince81 left a comment

Choose a reason for hiding this comment

PVince81 Sep 9, 2020

Choose a reason for hiding this comment

PVince81 commented Sep 10, 2020

PVince81 left a comment

Choose a reason for hiding this comment

butonic commented Sep 10, 2020

PVince81 left a comment

Choose a reason for hiding this comment