eos: fixed error reporting in the gRPC client

cs3org · Dec 17, 2024 · db70281 · db70281
1 parent fa972ee
commit db70281
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/changelog/unreleased/fix-eos-grpc-errors.md b/changelog/unreleased/fix-eos-grpc-errors.md
@@ -0,0 +1,5 @@
+Bugfix: fixed error reporting in the EOS gRPC client
+
+This in particular fixes the lock-related errors
+
+https://github.com/cs3org/reva/pull/5015
diff --git a/pkg/eosclient/eosgrpc/eosgrpc.go b/pkg/eosclient/eosgrpc/eosgrpc.go
@@ -216,7 +216,14 @@ func (c *Client) getRespError(rsp *erpc.NSResponse, err error) error {
 		return nil
 	}
 
-	return errtypes.InternalError("Err from EOS: " + fmt.Sprintf("%#v", rsp.Error))
+	switch rsp.Error.Code {
+	case 16: // EBUSY
+		return eosclient.FileIsLockedError
+	case 17: // EEXIST
+		return eosclient.AttrAlreadyExistsError
+	default:
+		return errtypes.InternalError(fmt.Sprintf("%s (code: %d)", rsp.Error.Msg, rsp.Error.Code))
+	}
 }
 
 // Common code to create and initialize a NSRequest.