refactor webdav publicfile

internal/http/services/owncloud/ocdav/publicfile.go

@@ -51,13 +51,13 @@ func (h *PublicFileHandler) Handler(s *svc) http.Handler {
 		if relativePath != "" && relativePath != "/" {
 			// accessing the file
 			// PROPFIND has an implicit call
-			if r.Method != "PROPFIND" && !s.adjustResourcePathInURL(w, r) {
+			if r.Method != MethodPropfind && !s.adjustResourcePathInURL(w, r) {
 				return
 			}
 
 			r.URL.Path = path.Base(r.URL.Path)
 			switch r.Method {
-			case "PROPFIND":
+			case MethodPropfind:
 				s.handlePropfindOnToken(w, r, h.namespace, false)
 			case http.MethodGet:
 				s.handlePathGet(w, r, h.namespace)
@@ -73,7 +73,7 @@ func (h *PublicFileHandler) Handler(s *svc) http.Handler {
 		} else {
 			// accessing the virtual parent folder
 			switch r.Method {
-			case "PROPFIND":
+			case MethodPropfind:
 				s.handlePropfindOnToken(w, r, h.namespace, true)
 			case http.MethodOptions:
 				s.handleOptions(w, r, h.namespace)
@@ -138,7 +138,7 @@ func (s *svc) handlePropfindOnToken(w http.ResponseWriter, r *http.Request, ns s
 	sublog := appctx.GetLogger(ctx).With().Interface("tokenStatInfo", tokenStatInfo).Logger()
 	sublog.Debug().Msg("handlePropfindOnToken")
 
-	depth := r.Header.Get("Depth")
+	depth := r.Header.Get(HeaderDepth)
 	if depth == "" {
 		depth = "1"
 	}
@@ -195,8 +195,8 @@ func (s *svc) handlePropfindOnToken(w http.ResponseWriter, r *http.Request, ns s
 		return
 	}
 
-	w.Header().Set("DAV", "1, 3, extended-mkcol")
-	w.Header().Set("Content-Type", "application/xml; charset=utf-8")
+	w.Header().Set(HeaderDav, "1, 3, extended-mkcol")
+	w.Header().Set(HeaderContentType, "application/xml; charset=utf-8")
 	w.WriteHeader(http.StatusMultiStatus)
 	if _, err := w.Write([]byte(propRes)); err != nil {
 		sublog.Err(err).Msg("error writing response")