-
Notifications
You must be signed in to change notification settings - Fork 113
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add logic and unit test to json driver
- Loading branch information
Showing
7 changed files
with
227 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| Enhancement: Add stubs and manager for groupprovider service | ||
|
|
||
| Recently, there was a separation of concerns with regard to users and groups in | ||
| CS3APIs. This PR adds the required stubs and drivers for the group manager. | ||
|
|
||
| https://github.com/cs3org/cs3apis/pull/99 | ||
| https://github.com/cs3org/cs3apis/pull/102 | ||
| https://github.com/cs3org/reva/pull/1358 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| // Copyright 2018-2020 CERN | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
| // In applying this license, CERN does not waive the privileges and immunities | ||
| // granted to it by virtue of its status as an Intergovernmental Organization | ||
| // or submit itself to any jurisdiction. | ||
|
|
||
| package json | ||
|
|
||
| import ( | ||
| "context" | ||
| "io/ioutil" | ||
| "os" | ||
| "reflect" | ||
| "testing" | ||
|
|
||
| grouppb "github.com/cs3org/go-cs3apis/cs3/identity/group/v1beta1" | ||
| userpb "github.com/cs3org/go-cs3apis/cs3/identity/user/v1beta1" | ||
| "github.com/cs3org/reva/pkg/errtypes" | ||
| ) | ||
|
|
||
| var ctx = context.Background() | ||
|
|
||
| func TestUserManager(t *testing.T) { | ||
| // add tempdir | ||
| tempdir, err := ioutil.TempDir("", "json_test") | ||
| if err != nil { | ||
| t.Fatalf("error while create temp dir: %v", err) | ||
| } | ||
| defer os.RemoveAll(tempdir) | ||
|
|
||
| // corrupt json object with user meta data | ||
| userJSON := `[{` | ||
|
|
||
| // get file handler for temporary file | ||
| file, err := ioutil.TempFile(tempdir, "json_test") | ||
| if err != nil { | ||
| t.Fatalf("error while open temp file: %v", err) | ||
| } | ||
|
|
||
| // write json object to tempdir | ||
| _, err = file.WriteString(userJSON) | ||
| if err != nil { | ||
| t.Fatalf("error while writing temp file: %v", err) | ||
| } | ||
|
|
||
| // get manager | ||
| input := map[string]interface{}{ | ||
| "groups": file.Name(), | ||
| } | ||
| _, err = New(input) | ||
| if err == nil { | ||
| t.Fatalf("no error (but we expected one) while get manager") | ||
| } | ||
|
|
||
| // clean up | ||
| os.Remove(file.Name()) | ||
|
|
||
| // json object with user meta data | ||
| userJSON = `[{"id":{"opaque_id":"sailing-lovers"},"group_name":"sailing-lovers","mail":"sailing-lovers@example.org","display_name":"Sailing Lovers","gid_number":1234,"members":[{"idp":"localhost","opaque_id":"einstein"},{"idp":"localhost","opaque_id":"marie"}]}]` | ||
|
|
||
| // get file handler for temporary file | ||
| file, err = ioutil.TempFile(tempdir, "json_test") | ||
| if err != nil { | ||
| t.Fatalf("error while open temp file: %v", err) | ||
| } | ||
| defer os.Remove(file.Name()) | ||
|
|
||
| // write json object to tempdir | ||
| _, err = file.WriteString(userJSON) | ||
| if err != nil { | ||
| t.Fatalf("error while writing temp file: %v", err) | ||
| } | ||
|
|
||
| // get manager - positive test | ||
| input = map[string]interface{}{ | ||
| "groups": file.Name(), | ||
| } | ||
| manager, _ := New(input) | ||
|
|
||
| // setup test data | ||
| gid := &grouppb.GroupId{OpaqueId: "sailing-lovers"} | ||
| uidEinstein := &userpb.UserId{Idp: "localhost", OpaqueId: "einstein"} | ||
| uidMarie := &userpb.UserId{Idp: "localhost", OpaqueId: "marie"} | ||
| members := []*userpb.UserId{uidEinstein, uidMarie} | ||
| group := &grouppb.Group{ | ||
| Id: gid, | ||
| GroupName: "sailing-lovers", | ||
| Mail: "sailing-lovers@example.org", | ||
| GidNumber: 1234, | ||
| DisplayName: "Sailing Lovers", | ||
| Members: members, | ||
| } | ||
| groupFake := &grouppb.GroupId{OpaqueId: "fake-group"} | ||
|
|
||
| // positive test GetGroup | ||
| resGroup, _ := manager.GetGroup(ctx, gid) | ||
| if !reflect.DeepEqual(resGroup, group) { | ||
| t.Fatalf("group differs: expected=%v got=%v", group, resGroup) | ||
| } | ||
|
|
||
| // negative test GetGroup | ||
| expectedErr := errtypes.NotFound(groupFake.OpaqueId) | ||
| _, err = manager.GetGroup(ctx, groupFake) | ||
| if !reflect.DeepEqual(err, expectedErr) { | ||
| t.Fatalf("group not found error differ: expected='%v' got='%v'", expectedErr, err) | ||
| } | ||
|
|
||
| // positive test GetGroupByClaim by mail | ||
| resGroupByEmail, _ := manager.GetGroupByClaim(ctx, "mail", "sailing-lovers@example.org") | ||
| if !reflect.DeepEqual(resGroupByEmail, group) { | ||
| t.Fatalf("group differs: expected=%v got=%v", group, resGroupByEmail) | ||
| } | ||
|
|
||
| // negative test GetGroupByClaim by mail | ||
| expectedErr = errtypes.NotFound("abc@example.com") | ||
| _, err = manager.GetGroupByClaim(ctx, "mail", "abc@example.com") | ||
| if !reflect.DeepEqual(err, expectedErr) { | ||
| t.Fatalf("group not found error differs: expected='%v' got='%v'", expectedErr, err) | ||
| } | ||
|
|
||
| // test GetMembers | ||
| resMembers, _ := manager.GetMembers(ctx, gid) | ||
| if !reflect.DeepEqual(resMembers, members) { | ||
| t.Fatalf("members differ: expected=%v got=%v", members, resMembers) | ||
| } | ||
|
|
||
| // positive test HasMember | ||
| resMember, _ := manager.HasMember(ctx, gid, uidMarie) | ||
| if resMember != true { | ||
| t.Fatalf("result differs: expected=%v got=%v", true, resMember) | ||
| } | ||
|
|
||
| // negative test HasMember | ||
| resMemberNegative, _ := manager.HasMember(ctx, gid, &userpb.UserId{Idp: "localhost", OpaqueId: "fake-user"}) | ||
| if resMemberNegative != false { | ||
| t.Fatalf("result differs: expected=%v got=%v", false, resMemberNegative) | ||
| } | ||
|
|
||
| // test FindGroups | ||
| resFind, _ := manager.FindGroups(ctx, "sail") | ||
| if len(resFind) != 1 { | ||
| t.Fatalf("too many groups found: expected=%d got=%d", 1, len(resFind)) | ||
| } | ||
| if !reflect.DeepEqual(resFind[0].GroupName, "sailing-lovers") { | ||
| t.Fatalf("group differ: expected=%v got=%v", "sailing-lovers", resFind[0].GroupName) | ||
| } | ||
| } |