Skip to content

Commit

Permalink
Merge pull request #4082 from kobergj/FixWebDavPermissions
Browse files Browse the repository at this point in the history
Fix PROPFIND permissions
  • Loading branch information
kobergj authored Jul 26, 2023
2 parents 08de0da + 02c6ae6 commit c444e4c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions changelog/unreleased/fix-propfind-permissions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Fix propfind permissions

Propfinds permissions field would always contain the permissions of the requested resource, even for its children
This is fixed.

https://github.com/cs3org/reva/pull/4082
2 changes: 1 addition & 1 deletion pkg/storage/utils/decomposedfs/decomposedfs.go
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,7 @@ func (fs *Decomposedfs) ListFolder(ctx context.Context, ref *provider.Reference,
for child := range work {
np := rp
// add this childs permissions
pset, _ := n.PermissionSet(ctx)
pset, _ := child.PermissionSet(ctx)
node.AddPermissions(&np, &pset)
ri, err := child.AsResourceInfo(ctx, &np, mdKeys, fieldMask, utils.IsRelativeReference(ref))
if err != nil {
Expand Down

0 comments on commit c444e4c

Please sign in to comment.