Provide a consistent userid over time to WOPI (#2155)

cs3org · Oct 12, 2021 · b7efeb1 · b7efeb1
1 parent d39f89c
commit b7efeb1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/changelog/unreleased/wopi-consistent-userid.md b/changelog/unreleased/wopi-consistent-userid.md
@@ -0,0 +1,6 @@
+Enhancement: pass an extra query parameter to WOPI /openinapp with a
+unique and consistent over time user identifier. The Reva token used so far
+is not consistent (it's per session) and also too long.
+
+https://github.com/cs3org/reva/pull/2155
+https://github.com/cs3org/wopiserver/pull/48
diff --git a/pkg/app/provider/wopi/wopi.go b/pkg/app/provider/wopi/wopi.go
@@ -139,6 +139,7 @@ func (p *wopiProvider) GetAppURL(ctx context.Context, resource *provider.Resourc
 	u, ok := ctxpkg.ContextGetUser(ctx)
 	if ok { // else defaults to "Guest xyz"
 		q.Add("username", u.Username)
+		q.Add("userid", u.Id.OpaqueId+"@"+u.Id.Idp)
 	}
 
 	q.Add("appname", p.conf.AppName)