Skip to content

Commit

Permalink
Update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
ishank011 committed Jun 4, 2021
1 parent 86954ea commit b154243
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
9 changes: 9 additions & 0 deletions changelog/unreleased/lw-user-types.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Enhancement: Add support for lightweight user types

This PR adds support for assigning and consuming user type when setting/reading
users. These changes are further required to enable setting varying access
scopes for different types of users, such as lightweight accounts which can only
access resources shared with them.

https://github.com/cs3org/reva/pull/1744
https://github.com/cs3org/cs3apis/pull/120
4 changes: 0 additions & 4 deletions changelog/unreleased/user-type.md

This file was deleted.

6 changes: 1 addition & 5 deletions internal/grpc/interceptors/auth/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ func NewUnary(m map[string]interface{}, unprotected []string) (grpc.UnaryServerI
return handler(ctx, req)
}

log.Info().Msgf("GRPC unary interceptor %s, %+v", info.FullMethod, req)

span.AddAttributes(trace.BoolAttribute("auth_enabled", true))

tkn, ok := token.ContextGetToken(ctx)
Expand Down Expand Up @@ -241,8 +239,6 @@ func dismantleToken(ctx context.Context, tkn string, req interface{}, mgr token.
if ref.GetPath() != "" {

// Try to extract the resource ID from the scope resource.
// Currently, we only check for public shares, but this will be extended
// for OCM shares, guest accounts, etc.
log.Info().Msgf("resolving path reference to ID to check token scope %+v", ref.GetPath())
for k := range tokenScope {
switch {
Expand Down Expand Up @@ -293,7 +289,7 @@ func checkResourcePath(ctx context.Context, ref *provider.Reference, r *provider
return false, err
}

// Since the public share is obtained from the scope, the current token
// Since the resource ID is obtained from the scope, the current token
// has access to it.
statReq := &provider.StatRequest{
Ref: &provider.Reference{
Expand Down

0 comments on commit b154243

Please sign in to comment.