Fix nil pointer exception when resolving members of a group (rest dri…

…ver) (#2265)
cs3org · Nov 11, 2021 · 9da0f15 · 9da0f15
1 parent a6eb9d5
commit 9da0f15
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/changelog/unreleased/fix-nil-exception-groups.md b/changelog/unreleased/fix-nil-exception-groups.md
@@ -0,0 +1,3 @@
+Bugfix: Fix nil pointer exception when resolving members of a group (rest driver)
+
+https://github.com/cs3org/reva/pull/2265
diff --git a/pkg/cbox/group/rest/rest.go b/pkg/cbox/group/rest/rest.go
@@ -346,7 +346,9 @@ func (m *manager) GetMembers(ctx context.Context, gid *grouppb.GroupId) ([]*user
 		if !ok {
 			return nil, errors.New("rest: error in type assertion")
 		}
-		users = append(users, &userpb.UserId{OpaqueId: userInfo["upn"].(string), Idp: m.conf.IDProvider})
+		if id, ok := userInfo["upn"].(string); ok {
+			users = append(users, &userpb.UserId{OpaqueId: id, Idp: m.conf.IDProvider})
+		}
 	}
 
 	if err = m.cacheGroupMembers(gid, users); err != nil {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Bugfix: Fix nil pointer exception when resolving members of a group (rest driver)

		https://github.com/cs3org/reva/pull/2265