Skip to content

Commit

Permalink
fix app provider for editor public links
Browse files Browse the repository at this point in the history
  • Loading branch information
David Christofas committed Nov 26, 2021
1 parent 0cb3bcb commit 7cfb544
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
8 changes: 8 additions & 0 deletions changelog/unreleased/fix-public-link-wopi.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Bugfix: Fix app provider for editor public links

Fixed opening the app provider in public links with the editor permission.
The app provider failed to open the file in read write mode.


https://github.com/owncloud/ocis/issues/2803
https://github.com/cs3org/reva/pull/2310
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,25 @@ func New(m map[string]interface{}, ss *grpc.Server) (rgrpc.Service, error) {
}

func (s *service) SetArbitraryMetadata(ctx context.Context, req *provider.SetArbitraryMetadataRequest) (*provider.SetArbitraryMetadataResponse, error) {
return nil, gstatus.Errorf(codes.Unimplemented, "method not implemented")
tkn, relativePath, err := s.unwrap(ctx, req.Ref)
if err != nil {
return nil, err
}

_, shareInfo, st, err := s.resolveToken(ctx, tkn)
switch {
case err != nil:
return nil, err
case st != nil:
return &provider.SetArbitraryMetadataResponse{
Status: st,
}, nil
}

p := path.Join("/", shareInfo.Path, relativePath)
ref := &provider.Reference{Path: p}

return s.gateway.SetArbitraryMetadata(ctx, &provider.SetArbitraryMetadataRequest{Opaque: req.Opaque, Ref: ref, ArbitraryMetadata: req.ArbitraryMetadata})
}

func (s *service) UnsetArbitraryMetadata(ctx context.Context, req *provider.UnsetArbitraryMetadataRequest) (*provider.UnsetArbitraryMetadataResponse, error) {
Expand Down

0 comments on commit 7cfb544

Please sign in to comment.