Fix panic when closing nats connection (#4016)

* fix panic when closing nats connection * add changelog
cs3org · Jun 28, 2023 · 63cd6aa · 63cd6aa
1 parent ba3d5b1
commit 63cd6aa
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/changelog/unreleased/fix-panic-nats-close.md b/changelog/unreleased/fix-panic-nats-close.md
@@ -0,0 +1,6 @@
+Bugfix: Fix panic when closing notification service
+
+If the connection to the nats server was not yet estabished,
+the service on close was panicking. This has been now fixed.
+
+https://github.com/cs3org/reva/pull/4016
diff --git a/pkg/notification/notificationhelper/notificationhelper.go b/pkg/notification/notificationhelper/notificationhelper.go
@@ -125,6 +125,10 @@ func (nh *NotificationHelper) connect() error {
 
 // Stop stops the notification helper.
 func (nh *NotificationHelper) Stop() {
+	if nh.nc == nil {
+		// service didn't connect yet to nat server
+		return
+	}
 	if err := nh.nc.Drain(); err != nil {
 		nh.Log.Error().Err(err)
 	}