Fixed error messages due to copy/paste (too much boiler-plate coding?) (

#1034)
cs3org · Jul 31, 2020 · 51106c7 · 51106c7
1 parent 6053083
commit 51106c7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/changelog/unreleased/fix-error-strings.md b/changelog/unreleased/fix-error-strings.md
@@ -0,0 +1,3 @@
+Bugfix: Fixed some error reporting strings and corresponding logs
+
+https://github.com/cs3org/reva/pull/1034
diff --git a/internal/grpc/services/gateway/appregistry.go b/internal/grpc/services/gateway/appregistry.go
@@ -30,7 +30,7 @@ import (
 func (s *svc) GetAppProviders(ctx context.Context, req *registry.GetAppProvidersRequest) (*registry.GetAppProvidersResponse, error) {
 	c, err := pool.GetAppRegistryClient(s.c.AppRegistryEndpoint)
 	if err != nil {
-		err = errors.Wrap(err, "gateway: error calling GetOCMShareProviderClient")
+		err = errors.Wrap(err, "gateway: error calling GetAppRegistryClient")
 		return &registry.GetAppProvidersResponse{
 			Status: status.NewInternal(ctx, err, "error getting user share provider client"),
 		}, nil
@@ -47,7 +47,7 @@ func (s *svc) GetAppProviders(ctx context.Context, req *registry.GetAppProviders
 func (s *svc) ListAppProviders(ctx context.Context, req *registry.ListAppProvidersRequest) (*registry.ListAppProvidersResponse, error) {
 	c, err := pool.GetAppRegistryClient(s.c.AppRegistryEndpoint)
 	if err != nil {
-		err = errors.Wrap(err, "gateway: error calling GetOCMShareProviderClient")
+		err = errors.Wrap(err, "gateway: error calling GetAppRegistryClient")
 		return &registry.ListAppProvidersResponse{
 			Status: status.NewInternal(ctx, err, "error getting user share provider client"),
 		}, nil

diff --git a/internal/grpc/services/gateway/usershareprovider.go b/internal/grpc/services/gateway/usershareprovider.go
@@ -367,15 +367,12 @@ func (s *svc) createReference(ctx context.Context, resourceID *provider.Resource
 
 	statRes, err := c.Stat(ctx, statReq)
 	if err != nil {
-		log.Err(err).Msg("gateway: error calling Stat for the share resource id:" + resourceID.String())
-		return &rpc.Status{
-			Code: rpc.Code_CODE_INTERNAL,
-		}, nil
+		return status.NewInternal(ctx, err, "gateway: error calling Stat for the share resource id: "+resourceID.String()), nil
 	}
 
 	if statRes.Status.Code != rpc.Code_CODE_OK {
 		err := status.NewErrorFromCode(statRes.Status.GetCode(), "gateway")
-		log.Err(err).Msg("gateway: error calling Stat for the share resource id:" + resourceID.String())
+		log.Err(err).Msg("gateway: Stat failed on the share resource id: " + resourceID.String())
 		return status.NewInternal(ctx, err, "error updating received share"), nil
 	}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Bugfix: Fixed some error reporting strings and corresponding logs

		https://github.com/cs3org/reva/pull/1034