cmd: check if config is initialized before assignment (#1116)

changelog/unreleased/ocm-fixes.md

@@ -1,3 +1,4 @@
-Bugfix: Minor fixes in OCM shares, gateway uploads and smtpclient
+Bugfix: Minor fixes in reva cmd, gateway uploads and smtpclient
 
 https://github.com/cs3org/reva/pull/1082
+https://github.com/cs3org/reva/pull/1116

cmd/reva/arguments.go

@@ -195,8 +195,14 @@ func (c *Completer) shareReceivedArgumentCompleter() []prompt.Suggest {
 }
 
 func executeCommand(cmd *command, args ...string) (bytes.Buffer, error) {
+
 	var b bytes.Buffer
 	var err error
+
+	if conf == nil || conf.Host == "" {
+		return b, errors.New("reva not configured")
+	}
+
 	if err = cmd.Parse(args); err != nil {
 		return b, err
 	}

cmd/reva/executor.go

@@ -46,10 +46,10 @@ func (e *Executor) Execute(s string) {
 	args := strings.Split(s, " ")
 
 	// Verify that the configuration is set, either in memory or in a file.
-	if conf.Host == "" {
+	if conf == nil || conf.Host == "" {
 		c, err := readConfig()
 		if err != nil && args[0] != "configure" {
-			fmt.Println("reva is not configured, please run the configure command")
+			fmt.Println("reva is not configured, please pass the -host flag or run the configure command")
 			return
 		} else if args[0] != "configure" {
 			conf = c