Do not swallow 'not found' errors in Stat

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
cs3org · Aug 26, 2020 · 3482177 · 3482177
1 parent 739d806
commit 3482177
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/changelog/unreleased/do-not-swallow-not-found-stat.md b/changelog/unreleased/do-not-swallow-not-found-stat.md
@@ -0,0 +1,5 @@
+Bugfix: Do not swallow 'not found' errors in Stat
+
+Webdav needs to determine if a file exists to return 204 or 201 response codes. When stating a non existing resource the NOT_FOUND code was replaced with an INTERNAL error code. This PR passes on a NOT_FOUND status code.
+
+https://github.com/cs3org/reva/pull/1124
diff --git a/internal/grpc/services/gateway/storageprovider.go b/internal/grpc/services/gateway/storageprovider.go
@@ -1051,6 +1051,11 @@ func (s *svc) Stat(ctx context.Context, req *provider.StatRequest) (*provider.St
 			}, nil
 		}
 		if res.Status.Code != rpc.Code_CODE_OK {
+			if res.Status.Code == rpc.Code_CODE_NOT_FOUND {
+				return &provider.StatResponse{
+					Status: status.NewNotFound(ctx, "gateway: file not found"),
+				}, nil
+			}
 			err := status.NewErrorFromCode(res.Status.Code, "gateway")
 			log.Err(err).Msg("gateway: error stating")
 			return &provider.StatResponse{