Merge pull request #4528 from DeepDiver1975/fix/cs3-metadata-upload-i…

…fnotexists fix: InitiateFileUploadRequest_IfNotExist options has to be set with …
cs3org · Feb 20, 2024 · 283b39b · 283b39b
2 parents 49b4a9e + 554384d
commit 283b39b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/changelog/unreleased/fix-metadata-storage-upload-ifnotexist.md b/changelog/unreleased/fix-metadata-storage-upload-ifnotexist.md
@@ -0,0 +1,3 @@
+Bugfix: Respect IfNotExist option when uploading in cs3 metadata storage
+
+https://github.com/cs3org/reva/pull/4528
diff --git a/pkg/storage/utils/metadata/cs3.go b/pkg/storage/utils/metadata/cs3.go
@@ -165,7 +165,9 @@ func (cs3 *CS3) Upload(ctx context.Context, req UploadRequest) (*UploadResponse,
 	}
 	if len(req.IfNoneMatch) > 0 {
 		if req.IfNoneMatch[0] == "*" {
-			ifuReq.Options = &provider.InitiateFileUploadRequest_IfNotExist{}
+			ifuReq.Options = &provider.InitiateFileUploadRequest_IfNotExist{
+				IfNotExist: true,
+			}
 		}
 		// else {
 		//   the http upload will carry all if-not-match etags
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Bugfix: Respect IfNotExist option when uploading in cs3 metadata storage

		https://github.com/cs3org/reva/pull/4528