-
Notifications
You must be signed in to change notification settings - Fork 113
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: use golang:alpine as base and re-enable CGO for revad (#1797)
- Loading branch information
1 parent
567ec47
commit 0a0f6c2
Showing
3 changed files
with
13 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,13 @@ | ||
Bugfix: Set CGO_ENABLED flag for 'scratch' based docker builds | ||
Bugfix: 'golang:alpine' as base image & CGO_ENABLED just for the CLI | ||
|
||
Some of the dependencies used by revad need CGO to be enabled in order to | ||
work. We also need to install the 'mime-types' in alpine to correctly | ||
detect them on the storage-providers. | ||
|
||
The CGO_ENABLED=0 flag was added to the docker build flags so that it will | ||
produce a static build. This allows usage of the 'scratch' image for | ||
reduction of the docker image size. | ||
reduction of the docker image size (e.g. the reva cli). | ||
|
||
https://github.com/cs3org/reva/issues/1765 | ||
https://github.com/cs3org/reva/pull/1766 | ||
https://github.com/cs3org/reva/pull/1766 | ||
https://github.com/cs3org/reva/pull/1797 |