Add Group API #98
Closed
Add Group API #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
labkode
reviewed
Nov 26, 2020
| rpc GetGroup(cs3.identity.group.v1beta1.GetGroupRequest) returns (cs3.identity.group.v1beta1.GetGroupResponse); | ||
| // Gets the information about a group based on a specified claim. | ||
| rpc GetGroupByClaim(cs3.identity.group.v1beta1.GetGroupByClaimRequest) returns (cs3.identity.group.v1beta1.GetGroupByClaimResponse); | ||
| // Gets the groups of a group. |
labkode
reviewed
Nov 26, 2020
| @@ -45,9 +45,11 @@ message UserId { | |||
| message User { | |||
| UserId id = 1; | |||
| string username = 2; | |||
There was a problem hiding this comment.
Here we can just add the new fields at the end to not limit the breakage.
ishank011
reviewed
Nov 26, 2020
| // Represents a group of the system. | ||
| message Group { | ||
| GroupId id = 1; | ||
| string groupname = 2; |
Yep, or you can just run |
|
moved to #99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a readonly groups api to CS3.
Similar to users groups have a persistent, non reassignable, stable, unique identifier which we call
idIn addition to that the CS3 API knows other identifiers like a name, an email and numeric identifiers (which we used to carry as opaque payload).
I did not care to preserve backwards compatability and reused old ids, which is why there are build failures for protobuf.
Let me know if we can go forward with this or if the API is considered staple and we need to keep backwards compatabililty.